Code Reviews - easy in theory, difficult in practice

The other day some of my coworkers and myself had a discussion about what it meant to do a code review. To my surprise it turned out that we had wildly different opinions on what it meant to have a pull request approved and what can be expected from the code reviewer. Some believed that code reviews are to check for bugs, performance issues and so forth. Others indicated that it is to check that we have made the correct thing. That the code does what the customer wants it to do. Others thought it was to check for code quality…